Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostgreSQL-based bookshop #244

Closed
wants to merge 1 commit into from
Closed

PostgreSQL-based bookshop #244

wants to merge 1 commit into from

Conversation

vmikhailenko
Copy link
Contributor

@vmikhailenko vmikhailenko commented Aug 1, 2023

Runnable (mvn spring-boot:test-run and from the IDE) and deployable (BTP-only) bookshop with PostgreSQL as the database. I adjusted the setup, removed everything that mocked S/4 HANA and rest of the stuff.

@vmikhailenko vmikhailenko reopened this Aug 1, 2023
@vmikhailenko vmikhailenko changed the title Temporary: PostgreSQL-based bookshop PostgreSQL-based bookshop Aug 1, 2023
@beckermarc
Copy link
Contributor

beckermarc commented Aug 1, 2023

Should we minimize the sample even further?

  • Minimize db CDS artifacts
  • Minimize srv CDS artifacts + custom code
  • Remove or minimize UI?

@vmikhailenko
Copy link
Contributor Author

Should we minimize the sample even further?

  • Minimize db CDS artifacts
  • Minimize srv CDS artifacts + custom code
  • Remove or minimize UI?

I would vote to remove Vue and Swagger. If the goal is to make the sample as slim as possible, we can leave only Books/Authors and administration of books to have read and write scenario.

@mofterdinger
Copy link
Member

mofterdinger commented Aug 1, 2023

I would vote to remove Vue and Swagger.

+1

about the complexity of the model I don't have an opinion, to be honest.

@mofterdinger mofterdinger added the ☠️ do not merge ☠️ Do not merge PR label Aug 1, 2023
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
srv/admin-service.cds Outdated Show resolved Hide resolved
mta.yaml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☠️ do not merge ☠️ Do not merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants