-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PostgreSQL-based bookshop #244
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmikhailenko
changed the title
Temporary: PostgreSQL-based bookshop
PostgreSQL-based bookshop
Aug 1, 2023
Should we minimize the sample even further?
|
I would vote to remove Vue and Swagger. If the goal is to make the sample as slim as possible, we can leave only Books/Authors and administration of books to have read and write scenario. |
+1 about the complexity of the model I don't have an opinion, to be honest. |
beckermarc
reviewed
Aug 3, 2023
beckermarc
reviewed
Aug 3, 2023
beckermarc
reviewed
Aug 3, 2023
beckermarc
reviewed
Aug 3, 2023
beckermarc
reviewed
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runnable (
mvn spring-boot:test-run
and from the IDE) and deployable (BTP-only) bookshop with PostgreSQL as the database. I adjusted the setup, removed everything that mocked S/4 HANA and rest of the stuff.